In most scenarios, your code changes or the areas of Feast that you are actively maintaining will only touch parts of the code(e.g one offline store/online store).
- 1.You should setup your fork so that you can make pull requests against your own master branch.
- This prevents unnecessary integration tests and other github actions that are irrelevant to your code changes from being run everytime you would like to make a code change.
- 2.When you are ready to merge changes into the official feast branch, make a pull request with the main feast branch and request a review from other maintainers.
- Since your code changes should only touch tests that are relevant to your functionality, and other tests should pass as well.
NOTE: Remember to frequently sync your fork master branch with
- Recommended: The github actions workflows that should be enabled on the fork are as follows:
- Runs all of the unit tests that should always pass.
- Lints your pr for styling or complexity issues using mypy, isort, and flake.
- Run all of the integration tests to test Feast functionality on your fork for a specific provider.
.github/workflowsfolder has examples of common workflows(
- 1.Move the
fork_pr_integration_tests_[provider].yml(more details below) to only run the integration tests that are relevant to your area of interest.
- 3.Push the workflow to your branch and it should automatically be added to the actions on your fork.
Fork specific integration tests are run by the
fork_pr_integration_tests.yml_[provider]yaml workflow files.
- 1.Under the
your github repowith your feast github repo name.
- 2.If your offline store/online store needs special setup, add it to the job similar to how gcp is setup.
- 3.Add any environment variables that you need to your github secrets.
- Access these by setting environment variables as
- 4.To limit pytest in your github workflow to test only your specific tests, leverage the
-koption for pytest.pytest -n 8 --cov=./ --cov-report=xml --color=yes sdk/python/tests --integration --durations=5 --timeout=1200 --timeout_method=thread -k "BigQuery and not dynamo and not Redshift"
- Each test in Feast is parametrized by its offline and online store so we can filter out tests by name. The above command chooses only tests with BigQuery that do not use Dynamo or Redshift.
- 5.Everytime a pull request or a change to a pull request is made, the integration tests, the local integration tests, the unit tests, and the linter should run.